search

ismayc / thesisdown

An updated R Markdown thesis template using the bookdown package
Other
809 stars 357 forks source link

add option to change line spacing #154

Closed simonpcouch closed 3 years ago

simonpcouch commented 3 years ago

Hey there!

The senior handbook currently advises that “Double-spaced and space-and-a-half are preferred” (p. 18). This PR adjusts the index.Rmd YAML to default to space-and-a-half and notes how to use single or double spacing instead. A less “breaking” change here could be continue defaulting to single-spaced but noting how to change spacing with similar code (a la 0ef60ec).

Not sure if inst/markdown is maintained anymore, but glad to drop these updates there if appreciated.

kbott and I checked in with library folks here to make sure we’re not introducing a change we ought not to.

Thank you for your work on maintaining this package. :-)

ismayc commented 3 years ago

I'm keeping inst around though I prefer people to use the RStudio project flow so inst will probably be deprecated at some point when most academic years aren't in session (likely over the summer). If you switch over that, I'm happy to merge into develop and then into master.

ismayc commented 3 years ago

Thanks for letting me know about this change too!

simonpcouch commented 3 years ago

You got it! Just made those changes and redirected the PR.

ismayc commented 3 years ago

Thanks, @simonpcouch!

github-actions[bot] commented 3 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org whenever possible) and link to this issue. If a reprex is not applicable, recording a short Loom video showing what you are seeing can go a long way in helping to diagnose problems.