search

ismir-mirex / nemadiy

Automatically exported from code.google.com/p/nemadiy
0 stars 1 forks source link

Analytics: Code Review #110

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I am making a list of issues related to the analytics code -need to address
these when Kris returns

1. FriedmansAnovaTkHsd -what's this class for? Can it be retired.
2. WriteCsvResultFile.java -Need to change this class name move the
functionality to utils
3. CopyFileFromClassPathToDisk.java Rename class -move functionality to a
util class
4. Move NemaFileType and nemaFileTypeImpl, OpaqueFileFormat and
RawAudioFile from the util package These are not util classes.
5. What are the classes in the util.process package, seem like either the
package is a misnomer or has redundant code or both...

Original issue reported on code.google.com by kumarami...@gmail.com on 3 May 2010 at 3:09

GoogleCodeExporter commented 9 years ago 
1. FriedmansAnovaTkHsd - performs all our stats tests (Friedmans ANOVA with Tk 
HSD 
using matlab. It needs to be replaced with a java implementation, however, this 
is 
not a trivial job.

2. WriteCsvResultFile.java - Yes, change name as it creates tabular data that 
then be 
written to either an HTML table or CSV file. Is used in every evaluator (and 
only in 
evaluators) to prep result data.

3. CopyFileFromClassPathToDisk.java - Move to an IO class?

4. Move NemaFileType and nemaFileTypeImpl, OpaqueFileFormat and
RawAudioFile from the util package These are not util classes.
- agreed

5. What are the classes in the util.process package, seem like either the
package is a misnomer or has redundant code or both...
- all of these are classes related to setting up (remote) processes, 
encoding/decoding command formatting strings etc. MatlabExecutorImpl runs 
matlab 
processes and is used to run the stats tests

Original comment by kris.west@gmail.com on 4 May 2010 at 2:54

GoogleCodeExporter commented 9 years ago 
Hey Kris -Stop working on your vacation!!! Enjoy Mexico :)

I created a 0.3.0-BRANCH that has the modifications to the package structure. 
Still
working on it.

Amit

Original comment by kumarami...@gmail.com on 4 May 2010 at 2:59