Open ltsypin opened 2 years ago
Hi @ltsypin, thanks for pointing this out. We are actually not using this dist_type
variable in the her.linkage
method since we are passing in a pre-calculated distance matrix, but we should not be passing in this variable. We can update this in the next release. Feel free to make a pull request or let me know if you have any other concerns.
I was digging a bit in the code to understand how the distance metric was implemented during clustering, and I think I found a bug:
In clustergrammer2/clustergrammer_fun/calc_clust.py, lines 80-93, it looks like neither the
scipy
norfastclust
libraries make use of thedist_type
parameter. Right now, the code is:Shouldn't it be
Y = hier.linkage(inst_dm, method=linkage_type, metric=dist_type)
for thescipy
case, for example?Thanks!