search

ismnoiet / jekyll-posts-generator

Generate jekyll posts from the terminal
10 stars 5 forks source link

added support for -t option #1

Closed andy5995 closed 6 years ago

andy5995 commented 6 years ago
ismnoiet commented 6 years ago

Thank you @andy5995 for your pull request, I will test it tomorrow or the day after and get back to you.

andy5995 commented 6 years ago

Sounds good.

I haven't tested it against your dev branch. I didn't realize that branch existed until after I'd made my changes.

I tested it by copying my revision to /lib/node_modules/jekyll-posts-generator/bin/jposts after I had installed the version available through npm.

I wasn't sure how to test a working copy. I assume it's a matter of editing the path so it will use all the files in my source tree directory.

Anyway, I did the PR against your 'dev' branch.

andy5995 commented 6 years ago

I rebased, corrected some errors, and I think we have as clean a commit log as we're gonna get! :)