search

ismop / dap

3 stars 0 forks source link

Consider visible as internal DAP mechanism #102

Open mkasztelnik opened 8 years ago

mkasztelnik commented 8 years ago

Currently UI should show only devices which are marked as visible. It would be nice if UI does not need to bother about it and visible would be internal DAP mechanism. It should be connected with all connected elements - e.g. bug https://github.com/ismop/eitwid/issues/91 was connected with that we were loading measurements for not visible devices.

So I propose:

  1. no devices returned by REST API with visible set to false
  2. no timelines connected with devices returned by REST API with visible set to false
  3. no measurements connected with timelines connected with devices returned by REST API with visible set to false
  4. no visible=true/false query param

@nowakowski, @bwilk, @dharezlak - what do you think about it?

nowakowski commented 8 years ago

I thought we already had this discussion, but fine. Could be tricky to implement optimally, esp. for measurements.

mkasztelnik commented 8 years ago

Issue I was mentioning was solved, but I'm not sure if other views do not have similar problems. Solution described by me will allow us to avoid such situations, since these sensors (with visible=false) are just wrong and should not be shown anywhere.