search

ismop / dap

3 stars 0 forks source link

Add profile name and populate it with correct names #180

Closed mkasztelnik closed 7 years ago

mkasztelnik commented 7 years ago

Profile object does not have name fields right now. As a results on the UI we are showing internal id on the UI - this is not user friendly for the end users (at least for DK). Please add name field to Profile and populate it with correct values.

This issue blocks https://github.com/ismop/dap/issues/179

bwilk commented 7 years ago

@nowakowski could you provide us with specification of profile_id/shape/location to "profile name" mapping ?

nowakowski commented 7 years ago

I'll try to get this done by Monday.

nowakowski commented 7 years ago

Done and pushed to prod. New attribute is called Profile.name. Syntax is:

Updated API, specs and docs.

@mkasztelnik Please close this ticket if satisfied.

dharezlak commented 7 years ago

The prefixes Profil neosentio and Profil budokop are not necessary here. We already know the vendor by looking at the vendors property. Also, it makes internationalization more difficult. This is a minor but I would fix it to minimize future UI hard coded commits to parse the name.

mkasztelnik commented 7 years ago

Looks good and it is already used by eitwid.

nowakowski commented 7 years ago

Reopening due to comment by @dharezlak .

My intent was to provide a human-readable name. If I truncate this to, say, 42, this may lead to confusion further down the line (i.e. a couple months from now when we all forget what this attribute means and why it was added). I can rewrite the names but I would advise against it. If you insist, please specify what you consider to be the "proper" syntax for the name field.

mkasztelnik commented 7 years ago

Right now I propose to leave it at it is and let user test the new behavior.

dharezlak commented 7 years ago

OK, closing.