search

ismrmrd / philips_to_ismrmrd

Philips to ISMRMRD converter
Other
17 stars 10 forks source link

Changes needed for Windows compatibility #1

Closed welcheb closed 9 years ago

hansenms commented 9 years ago

Does this compile with Visual Studio or cygwin or something else. How did you deal with the xslt stuff?

welcheb commented 9 years ago

Hi Michael,

I just sent you an email as you emailed me. Please let me know if there are more details you need to know.

I am compiling on Windows using Visual Studio Pro 2010. I can also create the executable at the command line using cl.exe with a command like this:

cl main.cpp pugixml.cpp /EHa /Fephilips_to_ismrmrd.exe /GS /TP /W3 /Zc:wchar_t- /Gm- /O2 /Ob2 /D “ IN32" /D "_WINDOWS" /D "NDEBUG" /D "_WIN32" /D "UNICODE" /D "_UNICODE" /D "_CRT_SECURE_NO_WARNINGS" /D "func=FUNCTION" /WX- /Zc:forScope /Gd /MD /I"C:/Libraries/iconv-1.9.2.win32/include/" /I"C:/Libraries/libxml2-2.6.30+.win32/include/" /I"C:/Libraries/boost/boost_1_55_0_x86/" /I"C:/Libraries/libxml2-2.6.30+.win32/include/" /I"C:/Libraries/libxslt-1.1.26.win32/include/" /I"C:/Libraries/install/ismrmrd_x86/include/" /link /libpath:"C:/Libraries/libxml2-2.6.30+.win32/lib/" libxml2.lib /libpath:"C:/Libraries/libxslt-1.1.26.win32/lib/" libxslt.lib /libpath:"C:/Libraries/install/ismrmrd_x86/lib/" ismrmrd.lib /libpath:"C:/Libraries/boost/boost_1_55_0_x86/lib32-msvc-12.0/" /DYNAMICBASE "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib" /VERBOSE

The main change was to compile everything including ismrmrd as 32-bit. I can prepare an update to the README.md page to explain the Windows steps.

Most importantly, the code still compiles on Mac.

From: Michael Hansen notifications@github.com<mailto:notifications@github.com> Reply-To: ismrmrd/philips_to_ismrmrd reply@reply.github.com<mailto:reply@reply.github.com> Date: Wednesday, August 19, 2015 at 12:11 PM To: ismrmrd/philips_to_ismrmrd philips_to_ismrmrd@noreply.github.com<mailto:philips_to_ismrmrd@noreply.github.com> Cc: "E. Brian Welch" brian.welch@vanderbilt.edu<mailto:brian.welch@vanderbilt.edu> Subject: Re: [philips_to_ismrmrd] Changes needed for Windows compatibility (#1)

Does this compile with Visual Studio or cygwin or something else. How did you deal with the xslt stuff?

— Reply to this email directly or view it on GitHubhttps://github.com/ismrmrd/philips_to_ismrmrd/pull/1#issuecomment-132698051.

hansenms commented 9 years ago

Sounds good. I will merge this. The easiest path forward on Windows may be cygwin and GCC.

welcheb commented 9 years ago

Thanks Michael!

From: Michael Hansen notifications@github.com<mailto:notifications@github.com> Reply-To: ismrmrd/philips_to_ismrmrd reply@reply.github.com<mailto:reply@reply.github.com> Date: Wednesday, August 19, 2015 at 12:19 PM To: ismrmrd/philips_to_ismrmrd philips_to_ismrmrd@noreply.github.com<mailto:philips_to_ismrmrd@noreply.github.com> Cc: "E. Brian Welch" brian.welch@vanderbilt.edu<mailto:brian.welch@vanderbilt.edu> Subject: Re: [philips_to_ismrmrd] Changes needed for Windows compatibility (#1)

Merged #1https://github.com/ismrmrd/philips_to_ismrmrd/pull/1.

— Reply to this email directly or view it on GitHubhttps://github.com/ismrmrd/philips_to_ismrmrd/pull/1#event-386771645.