search

isobar-nz / silverstripe-catalogmanager

Catalog administration via a LeftAndMain like interface. Lets you create and edit pages outside of the site tree
36 stars 26 forks source link

Update for SilverStripe 4.1+ #55

Closed hchokshi closed 6 years ago

stevie-mayhew commented 6 years ago

LGTM

Waiting on further review before merge.

tractorcow commented 6 years ago

Hi @hchokshi I made a bit of a mistake when reviewing this. I didn't realise you had pushed up to 4.1 directly (which was a branch for framework 3.x compatible framework).

In the future when you are getting work reviewed for merge into a repo on github can you please use a fork? You can follow https://help.github.com/articles/creating-a-pull-request-from-a-fork/ for instructions. This means that we can adjust the merge target prior to making the code available for users.

I've reset the 4.1 branch back to the last 3.x compatible commit, and merged this into master. You can get the 4.x compatible version of this module using 5.x-dev. Once we are happy this is stable we should tag 5.0.0 on master.

tractorcow commented 6 years ago

image

By the way, don't delete that! it's not safe lol.

tractorcow commented 6 years ago

Protected 4.1 :D