isobar-us / code-standards

Isobar Front-end development coding standards. Memorize them BY HEART.
https://isobar-us.github.io/code-standards/
1.34k stars 422 forks source link

Implement grunt build #37

Closed quoo closed 11 years ago

rcherny commented 11 years ago

Strictly speaking, this is a duplicate of the ticket #27 but since it's more specific, we'll close out the other.

rcherny commented 11 years ago

More information to come, but some notes around how this will work is available on ticket #12 as that is one of the primary requirements.

rcherny commented 11 years ago

The Grunt build script does not exist yet, though I have a proof of concept working from the old 0.3.0 Grunt code base.

Any work to implement a Grunt-based build system is welcome at this point.

Effectively we need the following:

The only reason for the (optionally) item above is the potential notion of doing pushState (HTML5 History) in the doc and loading partial page refreshes, but that is a TBD, so the second bullet is the real near term requirement.

So, in the end this is really a parent task for many other tasks.

Some pre-built options exist but I haven't had the time to review in detail to see if they meet all our criteria. Some of them include:

Please feel free to comment on this ticket and suggest alternative approaches, this isn't set in stone. What I might do is create a Wiki page here with the above requirements, if there is ultimately any confusion over what we would like to support.

roblarsen commented 11 years ago

You guys are going all mad scientist on this thing.

roblarsen commented 11 years ago

mad science

rcherny commented 11 years ago

LOL @roblarsen it's actually a lot simpler than it sounds, heh ... we just want the standards themselves to be separated from the page layout so it's more portable to others repos, etc.

Honestly, step one could be just "concatenate the HTML section files with the wrapper", which is effectively what we have always done, albeit with PHP.

Step two would then be run the file reads for each of those HTML through the markdown converter and call it a day.

But, I am mad, so I'll give you that.

@evandavis is most likely to do the Gruntfile work (not official, but I've had it on my plate for months...) since he's all over Grunt and I keep getting pulled into other chaos.

evandavis commented 11 years ago

@roblarsen to start I'm only adding SCSS compilation and some beautifier/minifiers. Don't get too excited.

roblarsen commented 11 years ago

I'm just egging you guys on.

rcherny commented 11 years ago

@roblarsen egg away, we could probably use some egging at this point ;-)

quoo commented 11 years ago

Yes to egging. Should we make that an issue too? ;)

roblarsen commented 11 years ago

@quoo I'll keep that in my back pocket for some day when I need to keep my Github contribution streak going

jaredwilli commented 11 years ago

I think the stuff that you guys are trying to do for this is great for the fact that it's continuing to be maintained as the living doc that it was intended to be. There's a lot of things that have changed in the past year which have made what this is supposed to be about as well as architecturally structured and follow itself.

Any egging or otherwise I may be able to contribute let me know. I'm happy to help, if/when I can. I'm working around the corner too now, on A st. We should all do lunch sometime :)

rcherny commented 11 years ago

@evandavis will assign to Evan to reflect reality and step 1, integration of SCSS.

rcherny commented 11 years ago

So close to the basics of what we need here. Please anyone looking into this touch base with @quoo if the pull requests haven't come through yet.