search

isogr / register-system-transition

Covers GR system transition from 2013 Java-based version to 2023 static site based version
1 stars 0 forks source link

sql2yaml: Superseding items do not get migrated #44

Closed strogonoff closed 4 months ago

strogonoff commented 4 months ago

If you look at “Successors” tab for transformation 484 is superseded with transformation 739.

This should be captured in YAML, but apparently isn’t.

It also is not captured in respective proposal info: supersedingItemIDs should not be empty, if the old system knows which item superseded this one.

strogonoff commented 4 months ago

The cause may be because this item was also invalidated, and so the status is “invalid”. However, because it was also superseded, we want it to have the appropriate info about superseding items attached.

For an example of how superseded info looks like in YAML, you can supersede an item using the proposal mechanism. I can provide more info if needed.

stefanomunarini commented 4 months ago

Possibly fixed with https://github.com/isogr/register-system-transition/commit/8b5aef10ba1fc12c9626e6c435165bf1caa501f1 . Awaiting confirmation for data correctness

strogonoff commented 4 months ago

@stefanomunarini not sure it’s fixed, maybe I wasn’t clear but we need to have item.supersedingItemIDs on the final item too (e.g. https://github.com/isogr/registry/blob/master/gr-registry/coordinate-ops--transformation/d68d502c-cb1e-4f72-a326-970c4aeee47d.yaml)

strogonoff commented 4 months ago

I.e. the main file outside of proposal/items

strogonoff commented 4 months ago

To see how it’s supposed to look like, just supersede any item and approve the proposal, then you will see the correct YAML.

stefanomunarini commented 4 months ago

To see how it’s supposed to look like, just supersede any item and approve the proposal, then you will see the correct YAML.

I am looking into doing this, however the button to "Create blank proposal" cannot be clicked. My user is registered in the register metadata with role "owner".

Am I missing any other step here @strogonoff ?

Screenshot 2024-02-20 at 12 45 15
stefanomunarini commented 4 months ago

And also, does this regard only Transformations dump, or shall this be for every single item class?

stefanomunarini commented 4 months ago

Superseding items have been added to all item class dump functions (https://github.com/isogr/register-system-transition/commit/70ab81bbb8d439e6a948b56311ef2c034923f4cf). However, it appears that only Transformation items have superseding items linked.