[Refactor] There should be one way to create new fields in the Isograph schema - Githubissues

isographlabs / isograph

The UI framework for teams that move fast — without breaking things.

MIT License

202 stars 9 forks source link

[Refactor] There should be one way to create new fields in the Isograph schema #51

Open rbalicki2 opened 2 months ago

rbalicki2 commented 2 months ago

In the process of running the compiler, we create client fields in (at least) these places:

when processing iso literals
when processing exposeField directives
when adding fields to concrete types that are defined on abstract types
when creating __refetch fields

When we do this, we do (at least!) three things:

push the client field onto schema.client_fields
push the client field ID onto parent_type.client_field_ids
add the field to parent_type.encountered_field

All three of those things should be combined into a single method. This may require #50