fix(rr): capture file extensions that are in uppercase - Githubissues

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

fix(rr): capture file extensions that are in uppercase #1016

Closed dcshzj closed 11 months ago

dcshzj commented 11 months ago

Problem

Our logs get a lot of false-positives that files are missing, but that is because our ALLOWED_FILE_EXTENSIONS does not take into account upper-case.

Solution

Breaking Changes

[ ] Yes - this PR contains breaking changes
[x] No - this PR is backwards compatible with ALL of the following feature flags in this doc

Bug Fixes:

Allow ReviewRequestService to check for the upper-case versions as well, and handle them as a proper image.
- NOTE: We are not allowing end-users to upload images with upper-case file extensions. This change is just to add support for backward compatibility.

Tests

[ ] Go to sla-geoworks site on CMS (ensure you have it cloned locally on your own GGS)
[ ] Check that the logs do not throw any errors regarding being unable to get the Git blob hash for uppercase file extensions.

Deploy Notes

None