hotfix(repair-form): set remote url correctly

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

hotfix(repair-form): set remote url correctly #1048

Closed kishore03109 closed 10 months ago

kishore03109 commented 10 months ago

Problem

The remore was not set properly. Reason why this error was not caught eariler was beacuse git itself is tolerant to this error, but our BE logic is not as we check a strict string check. Closes [insert issue #]

Solution

add .git at the end

kishore03109 commented 10 months ago

Current dependencies on/for this PR:

develop
- PR #1048 👈
- PR #1042
  - PR #1043
  - PR #1045
    - PR #1046
    - PR #1047
      - PR #1044

This stack of pull requests is managed by Graphite.

kishore03109 commented 10 months ago

@seaerchin yes gh handles this gracefully. In our rollback handlers however, we do a strict string check in the function call isRemoteOriginCorrect, which was how i discovered that error

fix is simple, we can just re-run the repair form later after release for all ggs that exist in efs (need to be done after hours)

seaerchin commented 10 months ago

eh dk why i didn't approve cos i clicked approve sia cb