ref(media): upgrade media router to typescript - Githubissues

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

ref(media): upgrade media router to typescript #1058

Closed dcshzj closed 10 months ago

dcshzj commented 10 months ago

Problem

The media router is in JavaScript.

Solution

Breaking Changes

[ ] Yes - this PR contains breaking changes
[x] No - this PR is backwards compatible with ALL of the following feature flags in this doc

Improvements:

Upgraded the two media routers to TypeScript.
Also combined MediaFilesRouter and MediaCategoriesRouter into a single MediaRouter. Having such a distinction can be confusing at times, especially when dealing with bulk actions.

No logic changes were made, only conversion into TypeScript.

Tests

Unit tests.

Deploy Notes

None

dcshzj commented 10 months ago

Route params and return types were inferred from their usages, along with the schema validations that were already present in the JS files. I agree tho, this would be more complete when the underlying services are migrated to TS.