ref(ts): migrated all files under directoryServices to Typescript - Githubissues

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

ref(ts): migrated all files under directoryServices to Typescript #1085

Closed QiluXie closed 6 months ago

QiluXie commented 9 months ago

Warning & FYI

The PR is quite big as there are 6 JS files migrated to TS. Please feel free to review a file at a time.
I intentionally left out all the unit test files under _test_ folder to avoid a PR that's too big to review. Will migrate them in a separate PR (and Jira ticket).

Problem

Closes IS-837

All files under the folder directoryServices are JS files without type safety

Solution

Migrated all files under directoryServices to TypeScript

Breaking Changes

[ ] Yes - this PR contains breaking changes
- Details ...
[ ] No - this PR is backwards compatible with ALL of the following feature flags in this doc

Improvements:

Migrated all files under directoryServices to Typescript

Tests

CI checks on the PR

mergify[bot] commented 6 months ago

This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers