fix(amplify): use rewrite instead of redirect for 404 error - Githubissues

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

fix(amplify): use rewrite instead of redirect for 404 error #1088

Closed dcshzj closed 9 months ago

dcshzj commented 9 months ago

Problem

We redirect when a page is not found instead of rewriting (to preserve the URL). This is semantically incorrect and causes SEO issues.

Solution

Breaking Changes

[ ] Yes - this PR contains breaking changes
[x] No - this PR is backwards compatible with ALL of the following feature flags in this doc

Features:

Details ...

Improvements:

Details ...

Bug Fixes:

Set the custom rule to rewrite instead of redirect. The 404-200 comes from their API reference.

Tests

Deploy Notes

None

dcshzj commented 9 months ago

Nope, we were wrong. It doesn't work if the site has been launched, weird.