build(deps): add parser as dep

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

build(deps): add parser as dep #1118

Closed kishore03109 closed 8 months ago

kishore03109 commented 8 months ago

Problem

adding relevant deps for upcomming prs regarding site link checker

note: change in dockerfile is needed here cuz i couldnt get the new package to download otherwise. we also should not be using node modules for consistency (notice node modules in the docker ignore)

New dependencies:

marked : this package was chosen in particular as it faster and produced better parsing than markdown-it, showdown
glob : implementation of glob in js
node:types: tbh i kinda forgot the error i faced when the lint just asked me to add it to the project deps, so just added it since this server side anyways

kishore03109 commented 8 months ago

@seaerchin

Just to check, running npm i from host then restarts the container right?

like npm i from local computer? for me it didnt leh:( like after npm i my npm run dev:server worked but my npm run dev didnt. not mounting this way fixed it

seaerchin commented 8 months ago

@seaerchin

Just to check, running npm i from host then restarts the container right?

like npm i from local computer? for me it didnt leh:( like after npm i my npm run dev:server worked but my npm run dev didnt. not mounting this way fixed it

Yea I meant after this npm i works. Sounds good to me theb

kishore03109 commented 8 months ago

Current dependencies on/for this PR:

#1148
#1121
#1119
#1118 👈
develop

This stack of pull requests is managed by Graphite.

kishore03109 commented 8 months ago

Merge activity

Feb 22, 3:02 AM EST: @kishore03109 started a stack merge that includes this pull request via Graphite.
Feb 22, 3:06 AM EST: @kishore03109 merged this pull request with Graphite.

mergify[bot] commented 7 months ago

⚠️ The sha of the head commit of this PR conflicts with #1166. Mergify cannot evaluate rules on this PR. ⚠️