fix(mergify): fix copy/paste mistake - Githubissues

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

fix(mergify): fix copy/paste mistake #1280

Closed seaerchin closed 6 months ago

seaerchin commented 6 months ago

Problem

merged previous mergify PR but managed to paste wrongly -> this resulted in all non sem-ver minor PRs up being merged.

this is

PR for base-64 (we don't use this - maybe can remove)
PR for marked -> we do use this! however, the change is to update marked to conform to changes in the markdown spec (to resolve ambiguity...)

Solution

change rule from minor -> major
looked at marked's 12.0 update here; ss attached below for convenience; as most of the changes are helpful to us (we only call marked.parse), i'm not going to rollback the PR

Breaking Changes

[ ] Yes - this PR contains breaking changes
- Details ...
[ ] No - this PR is backwards compatible with ALL of the following feature flags in this doc

Features:

Details ...

Improvements:

Details ...

Bug Fixes:

Details ...

Before & After Screenshots

BEFORE:

AFTER:

Tests

Deploy Notes

New environment variables:

env var : env var details
- [ ] added env var to 1PW + SSM script (fetch_ssm_parameters.sh)

New scripts:

script : script details

New dependencies:

dependency : dependency details

New dev dependencies:

dependency : dependency details