fix: off-by-one error for month number - Githubissues

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

fix: off-by-one error for month number #1294

Closed dcshzj closed 6 months ago

dcshzj commented 6 months ago

Problem

The month number has an off-by-one error as it is zero-indexed, which means for April, getMonth() will return 3 instead of 4.

Solution

Breaking Changes

[ ] Yes - this PR contains breaking changes
[x] No - this PR is backwards compatible with ALL of the following feature flags in this doc

Bug Fixes:

Fix the off-by-one error so that invalid dates (such as 2024-02-31 is not being produced erroneously).

Tests

[ ] Use the form for staging (find in 1PW) to request for the site audit logs
[ ] Request for logs for the previous calendar month for a site that exists on staging (and you are either an Isomer Admin or collaborator of)
[ ] Verify that the commits in the audit logs only show those in the previous calendar month (i.e. March)

Deploy Notes

None