fix(sitelaunch): do not throw for no dig results

[kishore03109]

Problem

When there was no records that were found, dns:node throws an error. While we did handle it, there should have been an additional return statement to exit early rather than propagating into an error state.

Solution

If the error is of type ENODATA, return early with some default values instead.

Breaking Changes

• [ ] Yes - this PR contains breaking changes
  • Details ...
• [X] No - this PR is backwards compatible with ALL of the following feature flags in this doc

Tests

Locally enter these values into support/routes/v2/formsg/index.ts

formsgSiteLaunchRouter
  .digAAAADomainRecords({
    primaryDomainSource: "singaopreoae.sg",
  } as SiteLaunchResult)
  .then(console.log)
  .catch(console.error)

formsgSiteLaunchRouter
  .digCAADomainRecords({
    primaryDomainSource: "singaopreoae.sg",
  } as SiteLaunchResult)
  .then(console.log)
  .catch(console.error)

assert that the console log outputs

Deploy Notes

This fix is meant to go into prod line asap

[kishore03109]

• #1355 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kishore03109 and the rest of your teammates on Graphite