isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

chore: log all sites retrieved #1394

Closed seaerchin closed 4 months ago

seaerchin commented 4 months ago

Problem

During debugging of the github login issue, a problem faced was determining whether the issue was internal (we using stale data) or external (github giving us stale data).

If we had the list of sites returned, it would have helped us to troubleshoot this issue.

Solution

This PR logs the list of sites as well as an identifier for the user's id. no sensitive information is logged in our system here. i didn't log any further down (this is done at SitesService) because any further down (eg: SitesCacheService) discards the userId, which is required for user identification