search

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

feat(rr): config parsing #662

Closed seaerchin closed 1 year ago

seaerchin commented 1 year ago

Problem

Our current model of parsing is simplified and only works for pages; this PR adds parsing for configuration files (nav + setting)

Closes IS-54

Solution

  1. add a config service that handles whether a file is a configuration file or not
  2. extend dto definitions to differentiate between the types
  3. in the event of failure, return the filename + folder path to the frontend to display
kishore03109 commented 1 year ago

CICD tests are failing, may I trouble you you to take a look at them?

seaerchin commented 1 year ago

CICD tests are failing, may I trouble you you to take a look at them?

kek i think the source branch is feat/buttons, which had tests fixed in #587 and #588; i'll probably rebase + merge those first and then rebase this on top once approved to see if the tests are still failing