isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

hotfix(0.18.1): merge into develop #674

Closed seaerchin closed 1 year ago

seaerchin commented 1 year ago

Problem

  1. old sites that are on github but not on db are mistakenly returned as 404 as the db query is empty
  2. DOMPurify too restrictive on BE

    Solution

  3. check data on github in addition to checking sites.
  4. use same setup as FE
seaerchin commented 1 year ago

Nits: we shouldnt have an additional call to github if the site already exists in our db. But since this is non-functional and more of an optimisation, we can tackle this after our hotfix!

yea but then it becomes q hard to read cos you have nested ifs