search

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

fix(authservice): return `userId` when e2e #700

Closed seaerchin closed 1 year ago

seaerchin commented 1 year ago

Problem

FE uses !!userId to determine if a user should be directed to the github login flow (which is what our tests work with), this requires a backend change to also return userId when it is the E2E_USER. separately, we should probably maintain 2 types of users for e2e (github + email) or, if we decide that we want to deprecate github in the future, make our existing tests compat w/ email flow Related to IS-87

Solution

add userId property when e2e

harishv7 commented 1 year ago

we should probably maintain 2 types of users for e2e (github + email) or, if we decide that we want to deprecate github in the future, make our existing tests compat w/ email flow

Have we created an epic/tickets for this?

seaerchin commented 1 year ago

we should probably maintain 2 types of users for e2e (github + email) or, if we decide that we want to deprecate github in the future, make our existing tests compat w/ email flow

Have we created an epic/tickets for this?

not at the moment cos i wanted to see which flow y'all would be more comfortable with. i'm just gonna file the comment as an issue as-is HAHA but just putting it here that i think maintaining 2 types of E2E (at first) is more robust

seaerchin commented 1 year ago

filed as IS-99