Currently, the emails that are being sent to operations is very bare. This had led to copy pasting errors before, leading to issues with the site launch process in the end / our users have complained that the this information is unclear. As a low handing fruit, this PR changes the way the DNS results are being rendered for lesser chances of error.
Closes IS-94
Solution
This PR has two main changes.
Adds inline HTML styles to make the tables look nicer, refer to the screenshots below for a visual change.
Refactoring of the code. Right now, our formSgSiteLaunch.ts has too much responsibility, I have created a SendDNSRecordEmailClient.ts whose responsibility would be to return the body of the email content.
Reviewer Notes
Feedback wanted: While I am certain I want to shift the logic needed to generate the body of the html to a separate file, not too sure where might be a best place to put the file SendDNSRecordEmailClient.ts in, open to feedback regarding this!
Breaking Changes
[ ] Yes - this PR contains breaking changes
Details ...
[X] No - this PR is backwards compatible
Before & After Screenshots
BEFORE:
AFTER:
Tests
_Step 0: Set your export MOCK_AMPLIFY_DOMAIN_ASSOCIATION_CALLS="true"_
Step 1. Run this from server.js to trigger a fake formsg response
Problem
Currently, the emails that are being sent to operations is very bare. This had led to copy pasting errors before, leading to issues with the site launch process in the end / our users have complained that the this information is unclear. As a low handing fruit, this PR changes the way the DNS results are being rendered for lesser chances of error.
Closes IS-94
Solution
This PR has two main changes.
formSgSiteLaunch.ts
has too much responsibility, I have created aSendDNSRecordEmailClient.ts
whose responsibility would be to return the body of the email content.Reviewer Notes
Feedback wanted: While I am certain I want to shift the logic needed to generate the body of the html to a separate file, not too sure where might be a best place to put the file
SendDNSRecordEmailClient.ts
in, open to feedback regarding this!Breaking Changes
Before & After Screenshots
BEFORE:
AFTER:
Tests
_Step 0: Set your
export MOCK_AMPLIFY_DOMAIN_ASSOCIATION_CALLS="true"
_ Step 1. Run this fromserver.js
to trigger a fake formsg responseStep 2: Refer to terminal output for resulting email content