isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

chore(aws region): shift from const -> env var #787

Closed seaerchin closed 1 year ago

seaerchin commented 1 year ago

Problem

AWS_REGION was previously referred to as either const in code or env var. this streamlines it to getting it from env vars (through convict).

Solution

  1. use config.get(aws.region)
    • logger in microservices not migrated due to it drawing in imports