We used to do a try catch to prevent breaking prod.
Solution
Now that we are confident that this works, we should remove the try,catch block to make full use of convict.
Breaking Changes
[ ] Yes - this PR contains breaking changes
Details ...
[X] No - this PR is backwards compatible
Tests
Doing a simple string search shows that we have had no errors in one week, and since we deployed last Thursday, we can deduce that all env vars that should be in prod + staging are in.
Deploy notes
Just make sure that FF_DEPRECATE_SITE_QUEUES and STEP_FUNCTIONS_ARN env var exists in staging and prod envs respectively. (supposed to go in as part of release process on 22 June 2023, this PR is written before that process has ended)
Problem
We used to do a try catch to prevent breaking prod.
Solution
Now that we are confident that this works, we should remove the
try,catchblock to make full use of convict.Breaking Changes
Tests
Doing a simple string search shows that we have had no errors in one week, and since we deployed last Thursday, we can deduce that all env vars that should be in prod + staging are in.
Deploy notes
Just make sure that
FF_DEPRECATE_SITE_QUEUESandSTEP_FUNCTIONS_ARNenv var exists in staging and prod envs respectively. (supposed to go in as part of release process on 22 June 2023, this PR is written before that process has ended)