Is 236 keep files not recognised as media

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

Closed caando closed 1 year ago

caando commented 1 year ago

.keep files are not being parsed properly because it exist in all folders despite not being whitelisted as a filetype.

Closes IS-236

Add a new placeholder filetype that handles all .keep files.

Bug Fixes:

ReviewRequestService.ts parses files in the order priority of config, media and page files.
Since .keep is not a recognised a valid media filetype, it gets treated as a page file.
Therefore the file has the wrong directory when making queries to Github API.

caando commented 1 year ago

Requesting for re-review as review request endpoints have been changed to filter placeholder files from change_files count and list of files.