This reverts commit 119476a9a88cbcaa70532560e5bbbc5c40718185.
Problem
I shot myself in the foot here @.@
The pain point I was trying to alleviate here was that setEmailSessionDefaults in the fe forces collab@e2e.gov.sg to be a contributor role, and my (wrong) assumption was that we were trying to maintain that invariant, so I thought it would be better to name it as such for clarity. After talking with chin, realised that we intend to make this collab also have the admin role if needed (or at least the intention behind this design is), which makes the changes introduced in #857 confusing as I can now have a contributor who has admin rights.
Solution
Revert changes. Tbh, it doesnt really solve the pain point I intended to solve, but I have a separate PR for this coming up!
This reverts commit 119476a9a88cbcaa70532560e5bbbc5c40718185.
Problem
I shot myself in the foot here @.@
The pain point I was trying to alleviate here was that
setEmailSessionDefaultsin the fe forcescollab@e2e.gov.sgto be a contributor role, and my (wrong) assumption was that we were trying to maintain that invariant, so I thought it would be better to name it as such for clarity. After talking with chin, realised that we intend to make this collab also have the admin role if needed (or at least the intention behind this design is), which makes the changes introduced in #857 confusing as I can now have a contributor who has admin rights.Solution
Revert changes. Tbh, it doesnt really solve the pain point I intended to solve, but I have a separate PR for this coming up!