isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

feat: Log 5xx errors for sms client #908

Closed kishore03109 closed 1 year ago

kishore03109 commented 1 year ago

Problem

Currently we are oblivious when Twilo goes down.

Solution

This logs a specific string which we can later use to to trigger alarm. We only log for 5xx errors since we dont want to trigger alarms for say invalid numbers.

However, since this is infra level stuff, this is a bit hard to test + cannot guarentee that there wont be any false positives. To monitor post deploy if this solution is ok.

Breaking Changes

Deploy Notes

Post release we would need to create a custom metric for our backend.std.out errors to match for Postman is returning 500 error for sending sms + create a corresponding alarm for that metric.