isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

feat(sl): enhance site launch process to utilise DNS indirection layer #920

Closed dcshzj closed 1 year ago

dcshzj commented 1 year ago

Problem

Closes IS-498.

Solution

Breaking Changes

Improvements:

Tests

The full site launch process will need to be executed. The tentative plan is to test this with a single site launch happening on the week of 28 August.

Deploy Notes

dcshzj commented 1 year ago

@kishore03109 Can I check for the existing redirection repo logic, do/should we also revert the change on site launch failure?

kishore03109 commented 1 year ago

Can I check for the existing redirection repo logic, do/should we also revert the change on site launch failure? wah hmm you raise a fair point. it makes sense for now to do so?

dcshzj commented 1 year ago

@kishore03109 I am deprioritising the reverting on site launch failure for now as I think the redirection and indirection stuff currently still has a manual component so we can easily catch and recover. Plus, the logic for creating the indirection DNS record also handles the case where the file already exists and will update the values inside.

I am thinking in the grander scheme of things, it is very unlikely that the agency will abort a site launch completely due to the technical errors we face when launching sites. Ultimately, we will retry the site launch again in the future and with our existing mechanisms in place to handle a potential existing file, I think reverting back to the original state is not as important.

kishore03109 commented 1 year ago

@kishore03109 I am deprioritising the reverting on site launch failure for now as I think the redirection and indirection stuff currently still has a manual component so we can easily catch and recover. Plus, the logic for creating the indirection DNS record also handles the case where the file already exists and will update the values inside. I am thinking in the grander scheme of things, it is very unlikely that the agency will abort a site launch completely due to the technical errors we face when launching sites. Ultimately, we will retry the site launch again in the future and with our existing mechanisms in place to handle a potential existing file, I think reverting back to the original state is not as important.

@dcshzj ok makes sense, we can go with this flow for now

dcshzj commented 1 year ago

Tested successfully on staging. The records were sent successfully via email:

Screenshot 2023-08-28 at 10 38 13 AM

The DNS records were also correctly set up on the isomer-indirections repository (see PR #12 and the Pulumi deployment).