isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

IS-312: Inject User Data into GrowthBook for Segmentation #927

Closed harishv7 closed 1 year ago

harishv7 commented 1 year ago

Problem

We need to have context of user attributes for us to do targeted rollouts/experiments.

Closes IS-312

Solution

We inject information at both the authentication and authorization middlewares based on what we know about the user at that point in time.

Note: To be reviewed in conjunction with IS-310 which introduces GrowthBook for BE.

Breaking Changes

harishv7 commented 1 year ago

Note: Tests will pass once #928 is merged into this

harishv7 commented 1 year ago

lgtm. Thanks @harishv7 for addressing the comments quickly. Should merge #928 first and make sure the CI testing passed before merging this one.

@QiluXie all checks have passed. merging now, thanks