isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

feat(template): add ffs as a manual check-in #933

Closed kishore03109 closed 1 year ago

kishore03109 commented 1 year ago

Problem

It is becoming harder for one eng to keep track of all the other feature flags that are avail. It is also well known a lot of production bugs in big tech companies are results for failed roll outs for experiments. (eg, amplify build times vs repo privatisation)

Closes [insert issue #]

Solution

Eng to manually tick off that their features are compat with the permutations of the features (or at least spend some time thinking intentionallu about it)

Breaking Changes

harishv7 commented 1 year ago

Can we change this to point to growthbook instead of having it listed manually here?

Intention is to reduce overhead + less changes have to be made when we go to 100%

@seaerchin we have some in env and growthbook. hence, we need a consolidated list somewhere

seaerchin commented 1 year ago

@seaerchin we have some in env and growthbook. hence, we need a consolidated list somewhere

yep - what i meant is that the growthbook env vars should just be a link to growthbook. otherwise, we'd need to maintain a duplicate (here, in the PR template and in growthbook also)

kishore03109 commented 1 year ago

@seaerchin instead linking to doc as sot