isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

Fix/e2e mutex #934

Closed alexanderleegs closed 1 year ago

alexanderleegs commented 1 year ago

Problem

This PR provides a temporary fix for the failing e2e tests due to our (now fixed) mutex lock. It removes the mutex lock from any endpoints hitting our e2e test repos. Note that this does not allow the tests to work with e2e test repos on the GGS system - those will still get blocked by the internal git system file lock which we are unable to bypass.

This solution is not ideal, but I've opted for this because it is the quickest way to resolve the issues - other methods require a more extensive sweep through our codebase to fix the failing tests. Swapping e2e test repo to use the mock lock also doesn't work as intended - this is because endpoints which lock the repo are being called concurrently (such as removeCollaborator), among others.

Resolves IS-535