IS-621: fix issues for staging deploy node 18 - Githubissues

isomerpages / isomercms-backend

A static website builder and host for the Singapore Government

5 stars 1 forks source link

IS-621: fix issues for staging deploy node 18 #951

Closed harishv7 closed 1 year ago

harishv7 commented 1 year ago

Problem

New Node env on AWS has issues with bcrypt as it depends on some C++ libs which probably don't exist.

Closes IS-621

Solution

Swapping to use bcryptjs which does not have such dependencies.

See this

Breaking Changes

[ ] Yes - this PR contains breaking changes
- Details ...
[X] No - this PR is backwards compatible with ALL of the following feature flags in this doc

Tests

Ensure all unit tests pass

Deploy Notes

Removed dependencies:

bcrypt: has compat issues with new node env

New dependencies:

bcryptjs : alternative for bcrypt

Removed dev dependencies:

@types/bcrypt : type defs for bcrypt

New dev dependencies:

@types/bcryptjs : type defs for bcryptjs