isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

feat(githubcommitService): add other req funcs #972

Closed kishore03109 closed 1 year ago

kishore03109 commented 1 year ago

Problem

Add in the remaining functions to enable functionality for Github Commit Service.

Closes [insert issue #]

Solution

Similar approach to how #970, but for gitfile.

Improvement

Right now it violates the single responsibility principle by doing more than just deciding what branch to commit to and what things to commit, but deprio the refactor in favour of releasing this feature out first.

Breaking Changes

Tests

[for documentation only, will be more explicit about these tests in the leaf PR]

For all gg whitelisted sites:

For whitelisted quickie sites -> all operations for CRUD on pages + assets should work as per normal, and commits should only appear in staging branch. All non assets should be committed to GitHub

For non-whitelisted quickie sites -> all operations for CRUD on pages + assets should work as per normal, and commits should only appear in staging branch.