isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

Feat/is 585 govt sgid login rollout #976

Closed alexanderleegs closed 1 year ago

alexanderleegs commented 1 year ago

Problem

This PR adds support for govt officials to log in via singpass. To be reviewed in conjunction with PR #1594 on the isomercms-frontend repo. It changes the existing sgin-login endpoint to return an email instead of just the status, and adds an additional endpoint to allow for users with multiple emails to call a separate endpoint to login after the initial sgid login step. It also modifies the existing behaviour of the add collaborators endpoint so that new users can be added as a collaborator directly instead of requiring them to log into the cms first.

Breaking Changes

Tests

seaerchin commented 1 year ago

Why would a user have separate emails?