isomerpages / isomercms-backend

A static website builder and host for the Singapore Government
5 stars 1 forks source link

feat: allow Isomer admins to edit on email-login and adjust permissions #982

Closed dcshzj closed 12 months ago

dcshzj commented 1 year ago

Problem

Closes IS-654.

Solution

Breaking Changes

Features:

Improvements:

Tests

Deploy Notes

None

kishore03109 commented 1 year ago

@dcshzj hmm wait we already have a table for isomer_admins, why not just make anyone who is an isomer_admin admin for all sites ah? this way we dont have to maintain a map of site_memeber_admins -> sites bah

dcshzj commented 1 year ago

@dcshzj hmm wait we already have a table for isomer_admins, why not just make anyone who is an isomer_admin admin for all sites ah? this way we dont have to maintain a map of site_memeber_admins -> sites bah

Hmm @kishore03109 are you able to clarify your comment? I'm using this table to determine who is an Isomer admin and enhancing existing endpoints to be able to retrieve this information from this isomer_admin table, so there is no adjustments made to the site_members table.

kishore03109 commented 1 year ago

Dont merge in today ya, we upgrading version today