isomorphic-git / lightning-fs

A lean and fast 'fs' for the browser
MIT License
477 stars 47 forks source link

Rename: file losing if exception threw #23

Closed lei-cao closed 4 years ago

lei-cao commented 4 years ago

https://github.com/isomorphic-git/lightning-fs/blob/master/src/CacheFS.js#L202 The oldFile is unlinked before the newFile is set correctly, when lookup fail, e.g. the newFilepath doesn't exist. the old file will be lost.

billiegoose commented 4 years ago

oh fudge. Good catch!

isomorphic-git-bot commented 4 years ago

:tada: This issue has been resolved in version 3.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: