search

isomorphic-git / lightning-fs

A lean and fast 'fs' for the browser
MIT License
476 stars 47 forks source link

fix: default mode for symlinks should be 0o120000 not 0o666 #43

Closed breadchris closed 4 years ago

breadchris commented 4 years ago

The default mode for symlinks was set to 0o666 which is not correct.

https://unix.superglobalmegacorp.com/Net2/newsrc/sys/stat.h.html#S_IFLNK #define S_IFLNK 0120000 /* symbolic link */

billiegoose commented 4 years ago

That... looks right. 🤔 Lemme just run the isomorphic-git tests to make sure I don't have any buggy assumptions in isomorphic-git.

OK, well, isomorphic-git tests pass so 🤞this is a lovely fix that won't break anything!

isomorphic-git-bot commented 4 years ago

:tada: This PR is included in version 4.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: