search

isonic1 / flick

A CLI with helpful QA tools for Android (Devices & Emulators) and iOS (Devices).
MIT License
101 stars 26 forks source link

Recorded Video Frame Rate is wrong #29

Closed erdoganonur closed 7 years ago

erdoganonur commented 7 years ago

https://github.com/isonic1/flick/blob/6cd7a31d6ae2b8c6831bc3c92eb200eb1b725bdf/lib/flick/video.rb#L146

Even if we change the duration of the screen capture interval, the fps is always 1. So the time actually spent in the recorded video will never be the same.

isonic1 commented 7 years ago

Yeah, you're right. This has been this way from the start. I added an argument to set the desired frame rate or defaults to 1 as it was before.

flick video -p android -a stop --rate 5

erdoganonur commented 7 years ago

Thanx, but the screenshots has irregular interval, so you cannot determine fps constantly. I think, it would be perfect if it was automatically calculated. I'll send you pull request.