search

isonic1 / flick

A CLI with helpful QA tools for Android (Devices & Emulators) and iOS (Devices).
MIT License
101 stars 26 forks source link

Fix issue with iPhoneX #43

Closed gdimitris closed 5 years ago

gdimitris commented 5 years ago

The problem Even though flick was generating the screenshots for iPhoneX the video produced was 0 bytes.

I saw that the images were passed to ffmpeg so I figured that the issue was there. Apparently, ffmpeg does not like the size of the screenshots and produced the following error: width not divisible by 2 (1125x2436)

The solution As you can see this is a one line fix, simply passing scale arguments to ffmpeg is enough. I think this does not break the vid creation for other devices.

Tested on: iOS

Android

gdimitris commented 5 years ago

This fixes https://github.com/isonic1/flick/issues/41

isonic1 commented 5 years ago

@gdimitris thank you for doing this! I'll be merging it soon with an updated version of Flick.