Fix video issue in Android

isonic1 / flick

A CLI with helpful QA tools for Android (Devices & Emulators) and iOS (Devices).

MIT License

101 stars 26 forks source link

Fix video issue in Android #44

Closed gdimitris closed 5 years ago

gdimitris commented 5 years ago

Hello @isonic1 ,

This is another PR from me :)

This fixes https://github.com/isonic1/flick/issues/39 and https://github.com/isonic1/flick/issues/40

The problem

Video for Android seems to not work for videos larger than 3 mins

The cause

Results from md5sum on the video directory were not parsed correctly. In detail, while the videos were saved correctly in sdcard/flick , the output was not split correctly causing only the first video to be output.

The solution

The solution is to use a regexp to parse the files correctly and add them into the hash for later processing. I also had to sort the results from Dir.glob because in my mac the results were not sorted causing wrong sequences in the final video.

gdimitris commented 5 years ago

@isonic1 I will also have some spare time to contribute this week so if you have any major issues to look at let me know.

isonic1 commented 5 years ago

@gdimitris thanks again for the help with this! It's much appreciated! ❤️ Outside of the issues you've fixed already I don't know of any others. A couple seem to be environmental issues but would need to doublecheck. I think the last thing I want to do for this project is to make it runnable on Windows (at least for android). But I wouldn't expect you to help with that unless you want to. :)

gdimitris commented 5 years ago

Happy to help, but I don't currently have a Windows machine at my disposal so it will take a while for that. I plan to make the following additions:

explicitly use screenshots instead of video on Android (for devices with low storage)
update the README with usage examples, since a lot of people seem to have difficulties
look into https://github.com/isonic1/flick/issues/33 since I also ran into it.
take a look into the specs. Tbh I still haven't managed to run them successfully since (from what I understand) they require both iOS and Android devices present. Perhaps they shouldn't be device dependent.

isonic1 commented 5 years ago

Thanks, @gdimitris. Those all sound great! Yeah, the specs really haven't been updated since I first pushed this repo a few years back. So any help with those would be awesome. I've gotten by with testing manually each time knowing I should update them. ;)

I guess one other thing I was going to look into adding iOS simulator recoding based on this feedback.

gdimitris commented 5 years ago

Ok perfect @isonic1 👍 , I can also check https://github.com/isonic1/flick/issues/11 I will let you know once I have something working