search

isontheline / pro.webssh.net

iOS / iPadOS / macOS SSH Client
https://apps.apple.com/us/app/id497714887
MIT License
276 stars 31 forks source link

Delete (left) Is Not Repeating #1098

Open ash34 opened 2 months ago

ash34 commented 2 months ago

Bug description

Using version 25.8.1329 on an iPad the delete key is not repeating. Virtual cursor key repeats ok though.

Steps to reproduce

  1. Use cursor up to select a previous command
  2. Trying deleting some of it with the delete key (backspace key)
  3. Only deletes one character at a time

Actually I noticed the problem in the previous release also but thought I was the faulty component.

isontheline commented 2 months ago

Hello @ash34 👋

I think I'm the faulty component due to this issue : https://github.com/isontheline/pro.webssh.net/issues/642

Thanks for your report, I'll check and make a fix

isontheline commented 2 months ago

By using the virtual keyboard?

ash34 commented 2 months ago

Yes, not a physical keyboard. I don’t have one to test with.

isontheline commented 2 months ago

OK so you are referring to the custom {DEL} Delete Key?

ash34 commented 2 months ago

I mean the key which is top-right on the keyboard. It deletes to the left. Also called backspace. Sent from my

isontheline commented 2 months ago

Seems to work as expected on my own : backspace

But perhaps a trouble may occur in some circumstances

ash34 commented 2 months ago

I have now update the steps to reproduce.

isontheline commented 2 months ago

@ash34 Perfect 🙏

isontheline commented 2 months ago

Issue https://github.com/isontheline/pro.webssh.net/issues/642 prevents the backspace key to be repeated when the text buffer is empty.

Text buffer is empty when we use previous history for example. Empty because WebSSH doesn't know what to put in the buffer.

I'm searching a solution to resolve #642 and backspace repeat