isontheline / pro.webssh.net

iOS / iPadOS / macOS SSH Client

https://apps.apple.com/us/app/id497714887

MIT License

305 stars 44 forks source link

locked / unlock loop #1101

Open stuntsman opened 5 months ago

stuntsman commented 5 months ago

Bug description

WebSSH 25.8 on iPadOS 17.3.1 is stuck in an unlock loop. A small dialog appears including "Locked" and an Unlock button. Clicking the button makes the dialog go away for a second then it comes back.

Screenshots

Steps to reproduce

Start app
Locked dialog appears, click Unlock
Dialog goes away for a second. Go to step 2.

Tried but didn't help:

killing the app (swipe up from bottom for app cards, swipe WebSSH card up to end process)
changing lock settings under Settings/WebSSH
disabling FaceID under Settings/WebSSH
restarting iPad

isontheline commented 5 months ago

Hello @stuntsman 👋

Does Face ID is enrolled on the device?

stuntsman commented 5 months ago

Thanks for the tip, I've found that FaceID was disabled:

a few days earlier I had to disable Passcode on the device temporarily, but then forgot about that
however disabling Passcode also automatically disabled FaceID (I didn't notice that until now)
since then WebSSH stuck in an unlock loop
re-enabling FaceID systemwide solved the issue (iPadOS required setting a passcode too)

Suggestion: the WebSSH unlock dialog could show a message if FaceID and/or passcode is disabled systemwide, as it seems to make unlocking impossible.

isontheline commented 5 months ago

Thanks for your strong feedback about your resolution 🙏

I will check if I can retrieve Face ID (full) enrollment from the Apple SDK and so improve WebSSH as well in order to avoid this check loop

isontheline commented 5 months ago

Merging this issue with this old one : https://github.com/isontheline/pro.webssh.net/issues/702