isontheline / pro.webssh.net

iOS / iPadOS / macOS SSH Client
https://apps.apple.com/us/app/id497714887
MIT License
276 stars 31 forks source link

Connections without a name : Ability to launch a favorite server from Home Screen Quick Actions #1142

Closed akuropka closed 1 week ago

akuropka commented 2 weeks ago

Relevant feature

https://github.com/isontheline/pro.webssh.net/issues/1082

Bug description

I am trying to use Home Screen Quick Actions to launch a server. I have set up servers as favorite and enabled the menu option but it seems no server appears. Other items such as meshREPL, Ping, Browser do appear if enabled.

Hard- / Software

iPhone 11 Pro on iOS 17.5.1 with WebSSH 26.4.1360 (App Store) iPhone 15 Pro Max on iOS 18 DB1 with WebSSH 26.4.1360 (Testflight)

Screenshots

Screenshot 2024-06-17 at 17 59 05 jpeg Screenshot 2024-06-17 at 17 59 46 jpeg Screenshot 2024-06-17 at 18 00 07 jpeg

isontheline commented 1 week ago

Hello @akuropka 👋

Please check that your connections have a "title" (name)

Works as expected when name is set :

image
akuropka commented 1 week ago

Hello @isontheline, 🙋‍♂️ this does the trick, thank you. 🙏 Good to know… I do not use names since the connection name (username@host) is clear enough for me. 😉 Maybe this can be implemented as fallback or somewhere a hint placed. By the way, it would be helpful, too, to be able just to favor one connection type, e.g. SSH, to avoid selection every time. 🧐

isontheline commented 1 week ago

Hello Andreas 👋

I'll implement the fallback 😉

By the way, it would be helpful, too, to be able just to favor one connection type, e.g. SSH, to avoid selection every time. 🧐

Sure but I "don't" know how to do it easily and how to present a clean GUI to the user

akuropka commented 1 week ago

From usability point of view it may be an option to implement a selection for the favorite same as for the roles. Another way would be to implement the favorite selection within the roles menu and have a drop down with the option enabled / disabled / favorite for each, imilar you have it for the Quick Actions.

The major work may be to rewrite the code to differentiate each favorite.

Basically it's just a usability issue... coming into my mind.

isontheline commented 1 week ago

By the way, it would be helpful, too, to be able just to favor one connection type, e.g. SSH, to avoid selection every time. 🧐

@akuropka I will open another issue for this new behaviour

I think I will be able to release the fallback later tomorrow

isontheline commented 1 week ago

Fallback now available on beta : https://testflight.apple.com/join/QSrBK59z

akuropka commented 1 week ago

@isontheline, works perfect, thanks.

isontheline commented 1 week ago

Thanks for your feedback @akuropka !

And thousand warm thanks for your support about my work 🙏 🎉 Thank you!!!