search

isontheline / pro.webssh.net

iOS / iPadOS / macOS SSH Client
https://apps.apple.com/us/app/id497714887
MIT License
317 stars 46 forks source link

Theme : Purple color should be named Magenta (ANSI) #1173

Closed isontheline closed 3 months ago

isontheline commented 3 months ago

Just want to start by saying I have been looking for an iOS SSH client that allows both custom ANSI themes + custom system fonts, and your app is the only one I could find - a be all, end all! I think this feature should be highlighted more.

That being said, I have found a few bugs with the custom ANSI themes:

  1. No matter the color they are set to in a theme, and no matter what theme you choose, Purple and Bright Purple are stuck being the same color scheme as the WebSSH theme. It is pretty easy to see the issue with themes like Desert or Seashells, which intentionally have no purples.

  2. In creating a custom theme, I cannot change the Cursor, background, foreground, and selection colors. I have tried everything I can to alter them in all of the tabs (Classic, Grid, RGB), but they just won't budge. I had to find a theme that had close enough values to what I wanted, clone it, and then edit the "other colors" (ansi codes).

  3. While I was successful in setting my other ANSI color codes, notably, the hex field in RGB refuses to set the color to that value. When exiting the screen, no changes are ever applied. I had to enter the RGB-256 values to set them correctly.

Thank you again for your app and time!

Originally posted by @oklopfer in https://github.com/isontheline/pro.webssh.net/discussions/1171

isontheline commented 3 months ago

Hello @oklopfer 👋

Thank you so much for your great and strong feedback about WebSSH 🙏

  1. No matter the color they are set to in a theme, and no matter what theme you choose, Purple and Bright Purple are stuck being the same color scheme as the WebSSH theme. It is pretty easy to see the issue with themes like Desert or Seashells, which intentionally have no purples.

Very good catch! I’m using “purple” and “brightPurple” instead of “magenta” and “brightMagenta” :( I will fix it asap in the next upcoming minor release.

  1. In creating a custom theme, I cannot change the Cursor, background, foreground, and selection colors. I have tried everything I can to alter them in all of the tabs (Classic, Grid, RGB), but they just won't budge. I had to find a theme that had close enough values to what I wanted, clone it, and then edit the "other colors" (ansi codes).

Oops seems to be a regression, I’m looking at it

  1. While I was successful in setting my other ANSI color codes, notably, the hex field in RGB refuses to set the color to that value. When exiting the screen, no changes are ever applied. I had to enter the RGB-256 values to set them correctly.

That’s strange I’ve just tested over iOS 17 and macOS 14 and I can apply hex values. The color is even updated when I focus another field.

Sorry @oklopfer for all these troubles I’m opening an issue to track them all : https://github.com/isontheline/pro.webssh.net/issues/1173

isontheline commented 3 months ago

@oklopfer about (2) : when you have made your changes to your custom theme -> please select it again in the list in order to be applied to your connection. Don't forget to save your connection (don't just go back).

Themes are not - yet - applied to your connections when you edit them.

oklopfer commented 3 months ago

@isontheline I can select the theme just fine, the problem is just that those 4 colors are uneditable for me.

EDIT: Ah, it appears to actually be the same as the hex issue - I am able to set with the RGB 256 values, but not the RGB hex values.

EDIT 2: Or maybe not. Background I was able to change. Selection/Cursor/Foreground I am not.

oklopfer commented 3 months ago

Putting this one in a new comment, sorry for so many edits - I have been able to trace down the source of the issue. If I swipe down to exit the RGB screen, the changes are not saved. But if I hit the X in the upper right corner, then it saves!

This is true for the hex issue, too.

isontheline commented 3 months ago

Many thanks for all your feedbacks!

So just point one (1) needs to be fixed?

oklopfer commented 3 months ago

That’s correct - the swiping vs hitting the X is a little clunky without knowing at first, but I can confirm I was able to set all of the colors properly now :)

isontheline commented 3 months ago

I admit that's clunky 😓 The library I use seems to have only a delegate about "colorPickerViewControllerDidFinish" and not about dismiss.

I will work on (1) soon

isontheline commented 3 months ago

Hello @oklopfer 👋

Please try WebSSH 27.3.1385 about magenta / purple color : https://testflight.apple.com/join/QSrBK59z

oklopfer commented 3 months ago

Can confirm it works! Thank you for such a quick fix and once again a perfect app, now my phone and laptop terminals are seamless :D

isontheline commented 3 months ago

Many thanks for your strong feedback about WebSSH 🙏