hunter-nl commented 3 years ago

Describe the bug Update 14.16 has changed the feature ‘snippets’. Before update I had different snippets per host configured. Now they all merged into 1 list and only the first 5 (alfabetische in the list) are shown as icon. This makes for me the snippets much less usable. Please restore the feature back to previous version.

Informations

Device : iPhone XS MAX
OS : iOS 14.15.1
WebSSH Pro version : 14.16.10

isontheline commented 3 years ago

Sorry to hear that this new intended behavior doesn't comply with your needs 😢 but it was a nightmare to maintain.

I need some time to think about your issue.

isontheline commented 3 years ago

Perhaps the best is to implement tags on snippets : a snippet could have a tag and the snippet will be displayed if the tag is the same as the host.

What do you think?

hunter-nl commented 3 years ago

If it is possible to assign multiple tags to snippets and hosts then that would be maybe a solution.

isontheline commented 3 years ago

@ash34 You seem to also use snippets in your connections :

Did you use also specific snippets per host?
Does tags assignation could be the ideal solution in order to split snippets per host?

ash34 commented 3 years ago

No sorry I use the same for every host. “sudo journalctl -b -o short-iso -n 20 -p err“ because the first thing I need to know is if there are any problems.

isontheline commented 3 years ago

Thanks for your feedback @ash34 👍

@hunter-nl I will so implement tags on hosts and snippets. Planned for current release 14.17 - Trèfle

mbierman commented 3 years ago

Tags would be a fine way to handle this. Maybe instead of free form tags a user could screw up, just have it so user can select the hosts they want the snippet available in or check boxes.

mbierman commented 3 years ago

I'm confused... is this still planned? What's the ETA?

isontheline commented 3 years ago

@mbierman Hello 👋

Still planned but still delayed in favour of bugs.
No ETA. I don't drive by ETA.
What about https://github.com/isontheline/pro.webssh.net/issues/309#issuecomment-859897583 ?

isontheline commented 3 years ago

Work In Progress : Ability to add tags on snippets and hosts

isontheline commented 3 years ago

Tags on servers and snippets - 14.0.8

From terminal	Server list	From settings

Explanations

You can add tags on both connections and snippets
If a connection and a snippet share at least one tag then they are linked
When a snippet is linked to a connection the snippet can be shown as a favorite for the given connection(s)
You can add as many tags as you want
When you don't add any tags on both then all connections and snippets are linked (default behavior)
If you want to link one snippet to all connections you can use a tag wildcard : just write the "*" wildcard character without quotes

isontheline commented 3 years ago

Hello @mbierman @hunter-nl @ash34 👋

I hope your are fine 🏖

Could you try WebSSH 15.0.8? https://testflight.apple.com/join/QSrBK59z

Have a nice day ☀️

mbierman commented 3 years ago

Hello @mbierman @hunter-nl @ash34 👋

I hope your are fine 🏖

I am indeed!

Could you try WebSSH 15.0.8? https://testflight.apple.com/join/QSrBK59z

I cannot get to snippets. Clicking the gear brings up the keyboard.

Have a nice day ☀️ You too.

isontheline commented 3 years ago

@mbierman Thanks for your feedback but I don't understand 😕

Are you sure that you don't press the search bar?
Are you running iOS 14 or iOS 15?
Could you make a video to replay the bug?

mbierman commented 3 years ago

Sure. I can’t use snippets at all because they aren’t selectable. All that happens is the keyboard opens.

https://youtu.be/b3VP2TlIp3E

isontheline commented 3 years ago

@mbierman OK I see 😬 sorry.

I will send a fix tonight.

mbierman commented 3 years ago

No worries. That’s what testing is for. Thank you

isontheline commented 3 years ago

Does WebSSH 15.0.9 fix the issue?

mbierman commented 3 years ago

@isontheline yes, but I don't understand how to assign snippets to one or more connections. Tags don't seem to do it.

isontheline commented 3 years ago

@mbierman When a connection and a snippet share at least one tag then they are linked.

There is a limit of five snippets that can be shown at same time (due to yesterday bug), but others snippets can be shown inside a list when you press the gear.

I have put in a previous comment three screenshots with tags examples.

mbierman commented 3 years ago

O.K. some feedback

It can be hard to edit the ssh list in some cases. See the last one, living room, in my list which is covered by the “+” button.
How can I add two tags? “A,b” “A/b” “A b”? Can tags have spaces? It would be nice if there was some example text in the UI to remind users.
Does capitalization matter?
Maybe there can be a default tag for connections? Hostname or IP? Initially I applied tags to snippets and nothing happened.

isontheline commented 3 years ago

@mbierman

I have planned a fix thank you! Workaround : you can also edit a connection by long pressing a row.
Tags can be separated by any of these chars : ,;/-| and space. You can mix the separators on the same line. OK I have added a reminder issue.
Tags are always capitalized. It's "not possible" to add a lower case tag (or should be reported as bug).
By default a blank tag is applied so all snippets are linked to all connections. If you add a tag to a snippet, the same tag should applied to a connection in order to link them. You can also use the wildcard * to link a snippet to all connections.

isontheline commented 3 years ago

@mbierman Does my previous feedback answers all your questions or do you need more information?

mbierman commented 3 years ago

So if space is a valid separator can you quote two words to have a tag with a space?

isontheline commented 3 years ago

No - yet - only one word tags are supported in order to reduce complexity of implementation.

isontheline / pro.webssh.net

Snippets per host/group #272

Tags on servers and snippets - 14.0.8

Explanations