isontheline / pro.webssh.net

iOS / iPadOS / macOS SSH Client
https://apps.apple.com/us/app/id497714887
MIT License
312 stars 46 forks source link

Private Key Import : Ask user if we should store the passphrase along the imported PKey #855

Open vdrover opened 1 year ago

vdrover commented 1 year ago
This issue have been updated : it's not a bug but a feature request > When you add the key manually, the key editor is shown and the passphrase field is clear. > > When you import the private key, the key editor is not open after the import. In this case, it was not obvious that I could edit the key. I understand now, but maybe opening the key editor after import would be more intuitive. # Bug description I added my SSH profile which connects with public/private keys. Upon first connecting, I must provide the passkey. The passkey was only needed for the first login. After enabling iCloud sync (or near that time), i have to enter the passkey EVERY time. Once the passkey (or password in the screenshot) is entered, it should not be needed again. Please advise. # Screenshots ![Servers (SSH) 2023-03-29 at 5 16 02 PM](https://user-images.githubusercontent.com/3143313/228680211-9397e923-45b9-4265-be4d-ad103b041c7b.jpg) # Steps to reproduce 1. I added my SSH profile which connects with public/private keys. 2. Upon first connecting, I must provide the passkey. 3. Disconnecting and reconnecting should no longer require the passkey. 4. Enable iCloud. 5. Connect from a second machine and enter passkey. 6. Original machine now requires passkey every time.
isontheline commented 1 year ago

Hello @vdrover Victor 👋

This popup is only about unlocking your private key once and the passphrase won't be synced through iCloud.

If you need to unlock your private key every time, you need to put your passphrase here :

image

If I don't have understand your need, please come back to me at any time.

Have a nice day ☀️

vdrover commented 1 year ago

I cannot locate a field for secret phrase. Connection 2023-03-30 at 8 59 10 AM

vdrover commented 1 year ago

I found it under the manual SSH key. Can you add this option when using a private key stored on the PC?

isontheline commented 1 year ago

@vdrover

Can you add this option when using a private key stored on the PC?

I'm sorry I don't have understand this statement. Could you tell me more about it?

vdrover commented 1 year ago

When you add the key manually, the key editor is shown and the passphrase field is clear.

When you import the private key, the key editor is not open after the import. In this case, it was not obvious that I could edit the key. I understand now, but maybe opening the key editor after import would be more intuitive.

isontheline commented 1 year ago

@vdrover You're right Victor!

I'm reopening this issue but with an updated title to reflect this improvement.

Thank you!

vdrover commented 1 year ago

Glad we got there !!