isontheline / pro.webssh.net

iOS / iPadOS / macOS SSH Client

https://apps.apple.com/us/app/id497714887

MIT License

305 stars 44 forks source link

New selection for copy will move xx lines up when keyboard disappears #909

Open MrFly72 opened 1 year ago

MrFly72 commented 1 year ago

Bug description

When you select a text to copy with the new method on iPad and the keyboard disappears, the selection will move up xx-lines.

Screenshots

https://github.com/isontheline/pro.webssh.net/assets/65505278/e05397b1-6088-48fb-ac1e-3fda35d0262a

isontheline commented 1 year ago

You're right @MrFly72 there is a trouble in this new implementation.

Thank you so much for your feedback 🙏

MrFly72 commented 1 year ago

Any news on this?

isontheline commented 1 year ago

No progress yet, I'm late on too many issues sorry

(Current workaround is to hide keyboard before selecting text)

isontheline commented 1 year ago

The best way for now is to disable keyboard hiding on screen touch.

I will release a new build soon with => #930

isontheline commented 1 year ago

I'm also thinking of disabling text selection for now as my implementation is so bad for users.

The "Show Scrollback Buffer" is a better solution instead (but I understand that it's not as native as requested)

MrFly72 commented 1 year ago

Don't know if that is the best solution. Scrollable buffer was always so small on iPad. Hard to select the right text.

isontheline commented 1 year ago

@MrFly72 If I improve the Scrollable Buffer (size pinching) would it be a "good" workaround before I can find time to improve text selection on the terminal itself?

MrFly72 commented 1 year ago

As it seems that I am anyhow maybe the only one requesting it or maybe using the iPad version a lot, go for it. I will somehow figure out how to work efficient with it.

isontheline commented 1 year ago

You are not the only one to complain about it @MrFly72

Some WebSSH users written me on the App Store and email.

I need to find the best way for everyone so you can use WebSSH as you expect it to be.

I hope I will improve it soon

isontheline commented 1 year ago

Scrollable buffer was always so small on iPad. Hard to select the right text.

@MrFly72 Would you like :

the same font size on both the terminal and the scrollback buffer (right now should be the same as terminal minus 1px or 2px I think)?
the ability to pinch in / out the scrollback buffer in order to change font size?

Or do you need any other improvement on the scrollback buffer